[PATCH] D75649: [mlir] Introduce OwningFuncRef following the same pattern as OwningModuleRef
    Mehdi AMINI via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Mar 11 09:04:41 PDT 2020
    
    
  
mehdi_amini added a comment.
In D75649#1916265 <https://reviews.llvm.org/D75649#1916265>, @rriddle wrote:
> That doesn't really make sense to me, OpBuilder::create generally inserts the operation into a block. I'm not sure what ownership semantics you are assigning to it here. Am I missing something? OpBuilder::create isn't a static method.
Ah of course you're right! I was thinking about Operation::create actually :) 
It is less often used directly though because of OpBuilder...
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75649/new/
https://reviews.llvm.org/D75649
    
    
More information about the llvm-commits
mailing list