[PATCH] D74691: [Attributor] Detect possibly unbounded cycles in functions

Stefanos Baziotis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 11 07:58:40 PDT 2020


baziotis added a comment.

In D74691#1916782 <https://reviews.llvm.org/D74691#1916782>, @omarahmed wrote:

> In D74691#1916738 <https://reviews.llvm.org/D74691#1916738>, @baziotis wrote:
>
> > In D74691#1916706 <https://reviews.llvm.org/D74691#1916706>, @omarahmed wrote:
> >
> > > Update commit message
> >
> >
> > Sorry probably it wasn't clear. I meant that you should also update the description of this patch. :)
>
>
> done :) , Does we need more details than that ?


I think it is ok. Although I haven't seen much the tests. Let's wait a couple of days for another reviewer and we can commit then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74691/new/

https://reviews.llvm.org/D74691





More information about the llvm-commits mailing list