[PATCH] D75695: [StackProtector] Catch direct out-of-bounds when checking address-takenness

[Matt Arsenault via Phabricator via llvm-commits]

arsenm requested changes to this revision.
arsenm added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/CodeGen/StackProtector.cpp:197-198
+      // object.
+      Type *ToType = I->getType()->getPointerElementType();
+      Type *FromType = I->getOperand(0)->getType()->getPointerElementType();
+      if (DL.getTypeAllocSize(ToType) > DL.getTypeAllocSize(FromType))
----------------
This is introducing new dependences on the deprecated pointee type. No decisions should be made based on this


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75695/new/

https://reviews.llvm.org/D75695