[PATCH] D75742: [Object] Support large archive members

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D75742#1916549 <https://reviews.llvm.org/D75742#1916549>, @grimar wrote:

> In D75742#1916519 <https://reviews.llvm.org/D75742#1916519>, @jhenderson wrote:
>
> > In D75742#1916287 <https://reviews.llvm.org/D75742#1916287>, @grimar wrote:
> >
> > > FTR.
> > >
> > > The current size of LLVM build folder for me is 26.1 Gb.
> > >  I think it is reasonable to avoid letting it go to 30.1 Gb (e.g. +4 Gb, +15%).
> > >
> > > We have `huge-temporarily-file.s` test in LLD with the following comment:
> > >
> > > > 1. This inputs previously created a 4gb temporarily file under 32 bit
> > > > 2. configuration. Issue was fixed. There is no clean way to check that from here.
> > > > 3. This testcase added for documentation purposes.
> > >
> > > I believe that +15% of peak free space consumption is probably too much. It might be better to
> > >  have no test at all sometimes.
> >
> >
> > We have or had that file? I couldn't find it in git as things stand.
>
>
> I believe we have it:
>  https://github.com/llvm/llvm-project/blob/master/lld/test/ELF/linkerscript/huge-temporary-file.s


Thanks. I didn't look in the linkerscript directory.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75742/new/

https://reviews.llvm.org/D75742