[PATCH] D75966: [ELF] Move --print-map(-M)/--cref before checkSections() and openFile()

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 11 00:09:25 PDT 2020


grimar added inline comments.


================
Comment at: lld/test/ELF/linkerscript/output-too-large.s:7
 
-# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
-# RUN: echo "SECTIONS { .text : { . = 0x8fffffffffffffff; *(.text*); } }" > %t.script
-# RUN: not ld.lld --no-check-sections --script %t.script %t.o -o /dev/null 2>&1 | FileCheck %s
+# RUN: not ld.lld -T %t1.script %t1.o -M -o /dev/null 2>&1 | \
+# RUN:   FileCheck --check-prefixes=MAP1 %s
----------------
I'd add comments for each test case.


================
Comment at: lld/test/ELF/linkerscript/output-too-large.s:8
+# RUN: not ld.lld -T %t1.script %t1.o -M -o /dev/null 2>&1 | \
+# RUN:   FileCheck --check-prefixes=MAP1 %s
+
----------------
`MAP1,CHECK`?


================
Comment at: lld/test/ELF/linkerscript/output-too-large.s:13
+# MAP1-NEXT:        0        0 ffffffff     1         . = 0xffffffff
+# MAP1-NEXT: 100000000 100000000        1     4         {{.*}}.o:(.text)
+# MAP1:      error: section .text at 0x0 of size 0x100000001 exceeds available address space
----------------
The "align" calues are misaligned vertically.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75966/new/

https://reviews.llvm.org/D75966





More information about the llvm-commits mailing list