[PATCH] D75973: [mlir] Add support for non-identifier attribute names.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 23:00:31 PDT 2020


rriddle created this revision.
rriddle added a reviewer: mehdi_amini.
Herald added subscribers: llvm-commits, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar.
Herald added a project: LLVM.

In some situations the name of the attribute is not representable as a bare-identifier, this revision adds support for those cases by formatting the name as a string instead. This has the added benefit of removing the identifier regex from the verifier.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75973

Files:
  mlir/docs/LangRef.md
  mlir/lib/Analysis/Verifier.cpp
  mlir/lib/IR/AsmPrinter.cpp
  mlir/lib/Parser/Parser.cpp
  mlir/test/IR/parser.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75973.249556.patch
Type: text/x-patch
Size: 6783 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200311/ed8d5fef/attachment.bin>


More information about the llvm-commits mailing list