[PATCH] D75081: [CodeView] Align type records on 4-bytes when emitting PDBs

Tue Mar 10 16:59:04 PDT 2020

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

Thanks! I guess we never encountered non-aligned type records.

================
Comment at: lld/test/COFF/pdb-tpi-aligned-records.test:21
+    # and that triggers an alignement bug in the output .PDB.
+    SectionData:     '040000001000081003000000000000000000000000000600011200000000'
+    Types:
----------------
Are you sure we don't ignore SectionData? If you confirm the test fails if you remove the LF_PAD code before committing, that's good enough for me.

I guess to be doubly sure we could remove the `Types:` block below. I would expect yaml2obj to fall back to SectionData.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75081/new/

https://reviews.llvm.org/D75081