[PATCH] D75748: [X86] Replace (most) X86ISD::SHLD/SHRD usage with ISD::FSHL/FSHR generic opcodes (PR39467)

Tue Mar 10 16:26:22 PDT 2020

craig.topper accepted this revision.
craig.topper added a comment.

LGTM

================
Comment at: llvm/lib/Target/X86/X86ISelLowering.h:37
+      /// X86 funnel/double shift i16 instructions. These correspond to
+      /// X86::SHLDWx and X86::SHRDWx instructions which have different amt
+      /// modulo rules to generic funnel shifts.
----------------
RKSimon wrote:
> RKSimon wrote:
> > craig.topper wrote:
> > > What is the 'x' after the W?
> > The instruction suffix for the rr/rm/mr cases - I'll remove it.
> @craig.topper Other than this are you ok with the patch?
Yeah

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75748/new/

https://reviews.llvm.org/D75748