[PATCH] D75748: [X86] Replace (most) X86ISD::SHLD/SHRD usage with ISD::FSHL/FSHR generic opcodes (PR39467)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 15:54:12 PDT 2020


RKSimon marked an inline comment as done.
RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.h:37
+      /// X86 funnel/double shift i16 instructions. These correspond to
+      /// X86::SHLDWx and X86::SHRDWx instructions which have different amt
+      /// modulo rules to generic funnel shifts.
----------------
craig.topper wrote:
> What is the 'x' after the W?
The instruction suffix for the rr/rm/mr cases - I'll remove it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75748/new/

https://reviews.llvm.org/D75748





More information about the llvm-commits mailing list