[PATCH] D75722: [mlir][Linalg] Implement padding for linalg.conv and lowering to loops.
Han-Chung Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 10 15:22:02 PDT 2020
hanchung marked an inline comment as done.
hanchung added inline comments.
================
Comment at: mlir/lib/Dialect/Linalg/Transforms/LinalgToLoops.cpp:185
+
+ ValueHandle zeroIndex = std_constant_index(0);
+ SmallVector<ValueHandle, 8> conds;
----------------
nicolasvasilache wrote:
> Please add a `// TODO(ntv): add a level of indirection to linalg.generic.`
Should this for another line, i.e., if (!convOp.padding())?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75722/new/
https://reviews.llvm.org/D75722
More information about the llvm-commits
mailing list