[PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

Tue Mar 10 14:13:58 PDT 2020

dblaikie added a comment.

In D75929#1915009 <https://reviews.llvm.org/D75929#1915009>, @labath wrote:

> I haven't digested the patch yet, but I am wondering if you've seen the recent discussion (`DWP mixed (DWARFv4/pre-standard + DWARFv5) content`) on dwarf-discuss (link1 <http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2020-February/thread.html>, link2 <http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2020-March/thread.html>), which is very relevant for this patch.
>
> If you have any opinions on that, it's not too late to join in. :)

+1 to that.

If not joining the conversation - the summary is basically: To support v4 and v5 units in a single DWP, extend the v5 index format with new-old columns: DW_SECT_LOC and 9 and DW_SECT_MACINFO at 10.

So probably keep the authoritative enum as this extended version of v5 - including DW_SECT_TYPES and 2, LOC and 9, and MACINFO at 10. And emit this extended index format any time the inputs contain at least one v5 unit.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75929/new/

https://reviews.llvm.org/D75929