[PATCH] D75932: Move RDF from Hexagon to Codegen

[Andy Kaylor via Phabricator via llvm-commits]

andrew.w.kaylor added inline comments.


================
Comment at: llvm/lib/CodeGen/RDFGraph.cpp:756
     LR.insert(RegisterRef(R));
-  if (RegisterId R = TLI.getExceptionSelectorRegister(PF))
-    LR.insert(RegisterRef(R));
+  if (!isFuncletEHPersonality(classifyEHPersonality(PF))) {
+    if (RegisterId R = TLI.getExceptionSelectorRegister(PF))
----------------
zbrid wrote:
> Thanks for this patch! Qq, is this some functionality change? Why does the refactor  require this update?
The original RDF implementation didn't need to handle Windows targets. The TLI::getExceptionSelectionRegister() method has an assertion testing that it is not called for Windows EH personality functions. There is no exception selector register on Windows.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75932/new/

https://reviews.llvm.org/D75932