[PATCH] D75956: [mlir] [VectorOps] Progressively lower vector.outerproduct to LLVM

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/include/mlir/Dialect/VectorOps/VectorOps.h:68
+
+// TODO(ajcbik): remove when external references are renamed too
+#define populateVectorContractLoweringPatterns                                 \
----------------
Let's remove this now.


================
Comment at: mlir/lib/Dialect/VectorOps/VectorTransforms.cpp:901
+      Value m;
+      if (acc != nullptr) {
+        Value z = rewriter.create<vector::ExtractOp>(loc, rhsType, acc, pos);
----------------
nit: `if (acc) {`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75956/new/

https://reviews.llvm.org/D75956