[PATCH] D75953: [mlir] Add derived attribute op interface

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/include/mlir/Analysis/DerivedAttributeOpInterface.h:2
+//===- DerivedAttributeOpInterface.h ----------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
----------------
Can we move this to the newly added Interfaces/ directory?


================
Comment at: mlir/include/mlir/Analysis/DerivedAttributeOpInterface.h:17
+#include "mlir/IR/OpDefinition.h"
+#include "mlir/Support/LLVM.h"
+#include "llvm/ADT/StringRef.h"
----------------
I believe you should only need OpDefinition.h here.


================
Comment at: mlir/include/mlir/Analysis/DerivedAttributeOpInterface.td:20
+  let description = [{
+    Interface to query derived attribute characteristics.
+  }];
----------------
Can you provide more detail here on what derived attributes are?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75953/new/

https://reviews.llvm.org/D75953