[PATCH] D75874: [mlir][spirv] Use SmallVector<ArrayRef> for availability queries
Mahesh Ravishankar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 10 12:33:59 PDT 2020
mravishankar requested changes to this revision.
mravishankar added a comment.
This revision now requires changes to proceed.
Do we need to autogen these? Can we have a simple utility method instead of generating this. Its a bit hard to parse.
================
Comment at: mlir/include/mlir/Dialect/SPIRV/SPIRVAvailability.td:50
+ // The code for preparing a concrete instnace. This should be C++ statements
+ // and will be generated before the `mergeAction` logic.
----------------
nit : s/instnace/instance
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75874/new/
https://reviews.llvm.org/D75874
More information about the llvm-commits
mailing list