[PATCH] D75871: [mlir][spirv] NFC: put SPIR-V attributes in separate files

Mahesh Ravishankar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 12:00:50 PDT 2020


mravishankar added a comment.

I am not sure its a good idea having so many headers. I am OK with having all of them in the same file. In this case specifically, the interface ABI and the target-env, vce attributes are needed for clients who are trying to serialize to SPIR-V binary. It makes sense to have them in one file


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75871/new/

https://reviews.llvm.org/D75871





More information about the llvm-commits mailing list