[PATCH] D75868: [mlir][spirv] Use separate attribute for (version, capabilities, extensions)

Mahesh Ravishankar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 11:25:30 PDT 2020


mravishankar accepted this revision.
mravishankar added a comment.

This is awesome! Thanks!



================
Comment at: mlir/include/mlir/Dialect/SPIRV/TargetAndABI.h:59
+                           MLIRContext *context);
+  static VerCapExtAttr get(IntegerAttr version, ArrayAttr capabilities,
+                           ArrayAttr extensions);
----------------
Nit: can you just take an integer here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75868/new/

https://reviews.llvm.org/D75868





More information about the llvm-commits mailing list