[PATCH] D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 10 10:53:16 PDT 2020
rriddle added inline comments.
================
Comment at: mlir/lib/Target/LLVMIR/ConvertFromLLVMIR.cpp:63
private:
+ // Returns personality of `f` as a FlatSymbolRefAttr.
+ FlatSymbolRefAttr getPersonalityAsAttr(llvm::Function *f);
----------------
nit: // -> ///
================
Comment at: mlir/lib/Target/LLVMIR/ConvertFromLLVMIR.cpp:769
+ if (auto ce = dyn_cast<llvm::ConstantExpr>(pf)) {
+ if (auto bc = dyn_cast_or_null<llvm::BitCastInst>(ce->getAsInstruction())) {
+ if (bc->getDestTy() ==
----------------
We shouldn't materialize an instruction here, you can just use `ce->getOpCode() == llvm::Instruction::BitCast`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71888/new/
https://reviews.llvm.org/D71888
More information about the llvm-commits
mailing list