[PATCH] D64962: appendToGlobalCtors: allow for llvm.global_ctors functions of varying type

[Anthony Eden via Phabricator via llvm-commits]

aeden added a comment.

> Relaxing it to Constant and asserting that it has the right type (pointer to void function) seems reasonable. I would prefer that the caller be the one to insert the cast from the `void(int, char**, char**)` prototype to the void prototype, since only the caller can know that it is safe.

Okay, sure.

> And it would need a test to proceed. A unit test would be best.

I've been really busy recently and haven't had a chance to do this. Sorry!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64962/new/

https://reviews.llvm.org/D64962