[PATCH] D75467: [instcombine] remove fsub to fneg hacks; only emit fneg

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 09:12:33 PDT 2020


spatel accepted this revision.
spatel added a comment.

LGTM - see inline for 1 more comment nit.



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp:2132
 
   // Subtraction from -0.0 is the canonical form of fneg.
+  // fsub -0.0, X ==> fneg X
----------------
This comment is stale. Remove or update to something like:
  // Convert fsub from zero to the canonical fneg instruction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75467/new/

https://reviews.llvm.org/D75467





More information about the llvm-commits mailing list