[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

[Hsiangkai Wang via Phabricator via llvm-commits]

HsiangKai marked an inline comment as done.
HsiangKai added inline comments.


================
Comment at: llvm/test/MC/RISCV/rvv/invalid.s:5
+vsetvli a2, a0, e31
+// CHECK-ERROR: operand must be e[8|16|32|64|128|256|512|1024],m[1|2|4|8]
+
----------------
fpallares wrote:
> Suggestion: If you use `CHECK-LABEL` between the regular `CHECK` you can avoid these directives to succeed by matching lines corresponding to a later instruction. Like this:
> 
> ```
> ​vsetvli a2, a0, e31
> // CHECK-ERROR: operand must be e[8|16|32|64|128|256|512|1024],m[1|2|4|8]
> // CHECK-ERROR-LABEL: ​vsetvli a2, a0, e31
> ```
> (Note the `CHECK-LABEL` is placed //after// the `CHECK` since it appears in this order in the output)
> 
> Without the `CHECK-LABELS` the test will still fail when something is wrong, but with them FileCheck will be able to point exactly where the problem occurred.
> 
> More info on this in the corresponding section of the [FileCheck manual](https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-label-directive).
Got it. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69987/new/

https://reviews.llvm.org/D69987