[PATCH] D75914: systemz: allow configuring default SystemZTargetCPU

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand added a comment.

Thanks for working on this!  A few comments inline.



================
Comment at: CMakeLists.txt:311
+  add_definitions( -DCLANG_SystemZTargetCPU="${CLANG_SystemZTargetCPU}" )
+endif()
+
----------------
Should be moved above the set(CLANG_VENDOR, ... line.

Also, this new variable itself have a set line, so that we can provide a descriptive text, and also move the "z10" default to here instead of the sources.

Finally, I think the mixed-case name doesn't really match the common naming conventions here, what about CLANG_SYSTEMZ_DEFAULT_ARCH ?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75914/new/

https://reviews.llvm.org/D75914