[PATCH] D75831: [mlir][Linalg] Revisit 0-D abstraction

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 06:58:53 PDT 2020


nicolasvasilache added a comment.

> This seems to have an affine_map for scalars being () -> (). This seems odd. Isn't it better to have a scalar access be (i,j) -> (), or something like that.

Whatever we do for 0-D is a convention, we can chose the convention we want.
`()->()` did not require parser changes whereas `(i, j) -> ()` does.

I went ahead and implemented those changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75831/new/

https://reviews.llvm.org/D75831





More information about the llvm-commits mailing list