[PATCH] D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode

[Jin Lin via Phabricator via llvm-commits]

jinlin added inline comments.


================
Comment at: clang/lib/CodeGen/CGObjCMac.cpp:5166
+    // the value should be i8 instead of i32. The type of the module
+    // flag should be Error.
+    Mod.addModuleFlag(llvm::Module::Error,
----------------
rjmccall wrote:
> I also meant this comment.
Removed.


================
Comment at: llvm/lib/IR/AutoUpgrade.cpp:4067
+      if (Md) {
+
+        assert(Md->getValue() && "Expected non-empty metadata");
----------------
rjmccall wrote:
> Spurious newline
Thanks for pointing out. Removed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71219/new/

https://reviews.llvm.org/D71219