[PATCH] D75899: [llvm-objdump] Simplify conditional statements (isa<...>(Obj) => Obj->isSomeFile())

[Xing via Phabricator via llvm-commits]

Higuoxing created this revision.
Higuoxing added reviewers: jhenderson, MaskRay.
Herald added subscribers: llvm-commits, rupprecht.
Herald added a project: LLVM.

Simplify some conditional statements.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75899

Files:
  llvm/tools/llvm-objdump/llvm-objdump.cpp


Index: llvm/tools/llvm-objdump/llvm-objdump.cpp
===================================================================
--- llvm/tools/llvm-objdump/llvm-objdump.cpp
+++ llvm/tools/llvm-objdump/llvm-objdump.cpp
@@ -1051,7 +1051,7 @@
 // TODO: implement for other file formats.
 static bool shouldAdjustVA(const SectionRef &Section) {
   const ObjectFile *Obj = Section.getObject();
-  if (isa<object::ELFObjectFileBase>(Obj))
+  if (Obj->isELF())
     return ELFSectionRef(Section).getFlags() & ELF::SHF_ALLOC;
   return false;
 }
@@ -1928,8 +1928,7 @@
     } else if (Section == O->section_end()) {
       outs() << "*UND*";
     } else {
-      if (const MachOObjectFile *MachO =
-          dyn_cast<const MachOObjectFile>(O)) {
+      if (MachO) {
         DataRefImpl DR = Section->getRawDataRefImpl();
         StringRef SegmentName = MachO->getSectionFinalSegmentName(DR);
         outs() << SegmentName << ",";
@@ -1939,13 +1938,13 @@
       outs() << SectionName;
     }
 
-    if (Common || isa<ELFObjectFileBase>(O)) {
+    if (Common || O->isELF()) {
       uint64_t Val =
           Common ? Symbol.getAlignment() : ELFSymbolRef(Symbol).getSize();
       outs() << '\t' << format(Fmt, Val);
     }
 
-    if (isa<ELFObjectFileBase>(O)) {
+    if (O->isELF()) {
       uint8_t Other = ELFSymbolRef(Symbol).getOther();
       switch (Other) {
       case ELF::STV_DEFAULT:
@@ -2001,7 +2000,7 @@
   }
 
   StringRef ClangASTSectionName("__clangast");
-  if (isa<COFFObjectFile>(Obj)) {
+  if (Obj->isCOFF()) {
     ClangASTSectionName = "clangast";
   }
 
@@ -2029,9 +2028,9 @@
 static void printFaultMaps(const ObjectFile *Obj) {
   StringRef FaultMapSectionName;
 
-  if (isa<ELFObjectFileBase>(Obj)) {
+  if (Obj->isELF()) {
     FaultMapSectionName = ".llvm_faultmaps";
-  } else if (isa<MachOObjectFile>(Obj)) {
+  } else if (Obj->isMachO()) {
     FaultMapSectionName = "__llvm_faultmaps";
   } else {
     WithColor::error(errs(), ToolName)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75899.249295.patch
Type: text/x-patch
Size: 1952 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200310/8989a299/attachment.bin>