[PATCH] D75793: [llvm-objdump] --syms: print 'i' for STT_GNU_IFUNC

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with one suggestion.



================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1902
       GlobLoc = Global ? 'g' : 'l';
+    char Ifunc = ' ';
+    if (auto *ELF = dyn_cast<ELFObjectFileBase>(O)) {
----------------
Maybe IFunc rather than Ifunc, since it's short for "Indirect Function"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75793/new/

https://reviews.llvm.org/D75793