[PATCH] D75452: [ARM][MVE] Validate tail predication values

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

LGTM, with one nit inline.



================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:582
+    // Only evaluate instructions which produce a single value.
+    if (MI.getNumDefs() != 1 || !MI.defs().begin()->isReg()) {
+      UnknownFalseLanes.insert(&MI);
----------------
samparker wrote:
> SjoerdMeijer wrote:
> > Is there a test for this?
> The only instructions that I can think of would be indexed load/stores, but they'll be caught by isVectorPredicated. If/When we can enable reductions, we could have an instruction producing two scalar values and then this logic will need to be reorganised a bit.
okidoki, then probably just remove this, or replace it with an assert?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75452/new/

https://reviews.llvm.org/D75452