[PATCH] D74516: Extend TimeTrace to LLVM's new pass manager
Anton Afanasyev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 9 23:21:55 PDT 2020
anton-afanasyev added a comment.
In D74516#1913475 <https://reviews.llvm.org/D74516#1913475>, @fedor.sergeev wrote:
> I'm sorry for the late comment, but this should have really been done through the PassInstrumentation framework.
> It looks like a classic use-case.
AFAII, this couldn't be done using `register[Before/After]PassCallback()` (like here `llvm/lib/IR/PassTimingInfo.cpp`) since profiler timer have to be assuredly finished if started, and that should be done directly by inserting `[start/stop]TimeProfiler()` in `run[Before/After/Pass/Invalidated]()`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74516/new/
https://reviews.llvm.org/D74516
More information about the llvm-commits
mailing list