[PATCH] D75837: Introduce std.execute_region op

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula added a comment.

In D75837#1913781 <https://reviews.llvm.org/D75837#1913781>, @mehdi_amini wrote:

> > To be generally useful for Linalg and other ops with regions that refuse to introduce SSA values prematurely (I.e. that use type information to encode the semantics and delay SSA value creation until inlining) you need both arguments and capture.
>
> I don't understand how explicit capture contributes to "refuse to introduce SSA values prematurely"? Can you provide an example of what you?
>  It isn't clear to me why would we keep arguments with such op instead of always canonicalizing towards eliminating them.


+1 This is also exactly what I wanted to say. If there were arguments in the land you were starting from (say you were inlining a call), those arguments should just get propagated and eliminated. Keeping arguments around will necessitate all kinds of tracking/bookkeeping in moving code across, reimplementing existing canonicalizations on this op and largely defeating the purpose of this op - which is to let SSA dominance and dataflow work freely from above and through it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75837/new/

https://reviews.llvm.org/D75837