[PATCH] D68063: Propeller: LLVM support for basic block sections

[Eric Christopher via Phabricator via llvm-commits]

echristo added a comment.

Couple of inline comments. I'm trying pretty hard to be able to get rid of TargetOptions.h some day if possible. Any thoughts on ways to do this without?



================
Comment at: llvm/include/llvm/Target/TargetOptions.h:71-72
+    All,    // Use Basic Block Sections for all functions.
+    Labels, // Do not use Basic Block Sections but label basic blocks.
+    List    // Get list of functions & BBs from a file
+  };
----------------
Can you describe the use case behind this in the comments?


================
Comment at: llvm/include/llvm/Target/TargetOptions.h:275-277
+    /// Memory Buffer that contains information on sampled basic blocks and used
+    /// to selectively generate basic block sections.
+    std::shared_ptr<MemoryBuffer> BBSectionsFuncListBuf;
----------------
Why would you want to be able to copy it again?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68063/new/

https://reviews.llvm.org/D68063