[PATCH] D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode

[Steven Wu via Phabricator via llvm-commits]

steven_wu added a comment.

It looks good in general. I would prefer to have two separate tests, one for upgrade, one for ir-linking.

I will have @rjmccall to have the final saying on this.



================
Comment at: llvm/lib/IR/AutoUpgrade.cpp:4083
+          ConstantAsMetadata::get(ConstantInt::get(Int32Ty,Module::Error)) :
+          Op->getOperand(0),
+          Op->getOperand(1),
----------------
Should we upgrade the first operand to `Error`? That also means you need to update your test case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71219/new/

https://reviews.llvm.org/D71219