[PATCH] D75718: [WebAssembly] Fixed FrameBaseLocal not being set.

Wouter van Oortmerssen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 9 16:12:37 PDT 2020


aardappel added a comment.

Even removing the debug decls at the end of the file still leaves a 37K very messy file that I would not want to add as a test :)

I am probably biased, but I don't think this is worth further effort. This is a small issue that very easily have been been written correctly initially (like so many bits of correct code for which we don't have explicit tests), it just wasn't.

I'm sure further coverage of debug functionality is yet to come.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75718/new/

https://reviews.llvm.org/D75718





More information about the llvm-commits mailing list