[PATCH] D75452: [ARM][MVE] Validate tail predication values

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

was just wondering about more corner cases for "negative" tests: do we have test where lanes are swapped (if that makes sense)?



================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:582
+    // Only evaluate instructions which produce a single value.
+    if (MI.getNumDefs() != 1 || !MI.defs().begin()->isReg()) {
+      UnknownFalseLanes.insert(&MI);
----------------
Is there a test for this?


================
Comment at: llvm/test/CodeGen/Thumb2/LowOverheadLoops/unpredicated-min.mir:1
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -mtriple=thumbv8.1m.main -mattr=+mve %s -run-pass=arm-low-overhead-loops -o - | FileCheck %s
----------------
nit: rename file unpredicated-min.mir -> unpredicated-max.mir?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75452/new/

https://reviews.llvm.org/D75452