[PATCH] D75868: [mlir][spirv] Use separate attribute for (version, capabilities, extensions)

[Lei Zhang via Phabricator via llvm-commits]

antiagainst created this revision.
antiagainst added a reviewer: denis13.
Herald added subscribers: llvm-commits, bader, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, shauheen, burmako, jpienaar, rriddle, mehdi_amini, jfb.
Herald added a reviewer: mravishankar.
Herald added a project: LLVM.
antiagainst added a child revision: D75869: [mlir][spirv] Use larger range for target environment lookup function.

We also need the (version, capabilities, extensions) triple on the
spv.module op. Thus far we have been using separate 'extensions'
and 'capabilities' attributes there and 'version' is missing. Creating
a separate attribute for the trip allows us to reuse the assembly
form and verification.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75868

Files:
  mlir/docs/Dialects/SPIR-V.md
  mlir/include/mlir/Dialect/SPIRV/SPIRVBase.td
  mlir/include/mlir/Dialect/SPIRV/TargetAndABI.h
  mlir/lib/Dialect/SPIRV/SPIRVDialect.cpp
  mlir/lib/Dialect/SPIRV/TargetAndABI.cpp
  mlir/test/Conversion/LinalgToSPIRV/linalg-to-spirv.mlir
  mlir/test/Dialect/SPIRV/availability.mlir
  mlir/test/Dialect/SPIRV/target-and-abi.mlir
  mlir/test/Dialect/SPIRV/target-env.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75868.249208.patch
Type: text/x-patch
Size: 50020 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200309/cc308af1/attachment.bin>