[PATCH] D75845: [ValueLattice] Add singlecrfromundef lattice value.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 9 14:03:35 PDT 2020


nikic added a comment.

Same comment as on D75055 <https://reviews.llvm.org/D75055>: For LVI we don't guarantee that all uses of the value will be replaced, so this does not seem like a completely fix. I'm generally not really clear on how this differs from the variant implemented in D75055 <https://reviews.llvm.org/D75055> (is it is just a matter of style, i.e. making this explicit, or is there a functional difference here?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75845/new/

https://reviews.llvm.org/D75845





More information about the llvm-commits mailing list