[PATCH] D73086: [WIP][DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a subscriber: jhenderson.
dblaikie added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:830
+  if (auto Err = MacinfoDWO->parse(this->getStringExtractor(), MacinfoDWOData,
+                                   false /* IsMacro */))
+    WithColor::defaultErrorHandler(std::move(Err));
----------------
SouraVX wrote:
> dblaikie wrote:
> > Here and below, I believe the format LLVM prefers for naming boolean parameters is:
> > ```
> > /*IsMacro=*/false
> > ```
> > Having the comment before the literal, and using '='
> > 
> > 
> Will do Thanks! for correcting this.
> BTW, do you have any thoughts on error handling, in this implementation ?
> Currently this implementation, handles errors while parsing(mostly macro section, but also bloats up `macinfo` too,/due to shared execution paths/), if any error encountered return(recoverable error) to caller and continue subsequent execution of `dump` routine which will eventually dump whatever has been correctly parsed and terminate finally.
I haven't been paying too much attention to error handling - but that sounds reasonable/consistent with other work in improving error handling in libDebugInfoDWARF.

@jhenderson might have the most context on error handling philosophies here, I think


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086