[PATCH] D68063: Propeller: LLVM support for basic block sections

[Sriraman Tallam via Phabricator via llvm-commits]

tmsriram added a comment.

In D68063#1908455 <https://reviews.llvm.org/D68063#1908455>, @efriedma wrote:

> I'm not completely comfortable passing the BB-sections list to the backend as a file path; generally we try to allow the "frontend" (clang/llc/etc.) to control all file I/O.  But I'm not sure what the alternative looks like.  I guess we could pass it as MemoryBuffer?
>
> Otherwise looks fine.




- Looking into this, it is not possible to keep the unique_ptr<MemoryBuffer> in TargetOptions.h as the assignment operator is deleted.
- I may have to store the MemoryBuffer in TargetMachine or find another home for it, in which case I may need special handling for both llc and LTO.
- I looked at how some other profile files are stored and noticed that for SampleProfileLoader, the file path is stored as a string in PassBuilder.h and the file seems to be read in the backend.

Thoughts? Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68063/new/

https://reviews.llvm.org/D68063