[PATCH] D75695: [StackProtector] Catch direct out-of-bounds when checking address-takenness

[John Brawn via Phabricator via llvm-commits]

john.brawn marked 5 inline comments as done.
john.brawn added inline comments.


================
Comment at: llvm/test/CodeGen/Generic/stack-guard-oob.ll:6
+; RUN: llc -mtriple=x86_64 -O0 < %s | FileCheck %s
+
+; CHECK-LABEL: in_bounds
----------------
probinson wrote:
> REQUIRES: aarch64-registered-target
> REQUIRES: arm-registered-target
> REQUIRES: x86-registered-target
> 
I think it makes more sense instead to split this into three separate tests (which just use the same input file in test/Codegen/Inputs, like we do with stack-guard-reassign.ll), so we don't need to requiring all targets if we want to test any of them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75695/new/

https://reviews.llvm.org/D75695