[PATCH] D75854: [mlir][ods] Fix AnyInteger predicate

Stephen Neuendorffer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 9 10:13:49 PDT 2020


stephenneuendorffer accepted this revision.
stephenneuendorffer added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/IR/OpBase.td:318
 // Any integer type irrespective of its width and signedness semantics.
-def AnyInteger : Type<CPred<"$_self.isInteger()">, "integer">;
+def AnyInteger : Type<CPred<"$_self.isa<IntegerType>()">, "integer">;
 
----------------
To be symmetric with isSignlessInteger() and other functions, maybe adding isInteger() which does the isa<IntegerType> check is a good idea?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75854/new/

https://reviews.llvm.org/D75854





More information about the llvm-commits mailing list