[PATCH] D75771: [mlir] NFC - Add predicates and types for VectorOfRank
Aart Bik via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 9 09:41:17 PDT 2020
aartbik accepted this revision.
aartbik added inline comments.
================
Comment at: mlir/include/mlir/IR/OpBase.td:490
+// `allowedRanks` list
+class IsVectorOfRankPred<list<int> allowedRanks> :
+ And<[IsVectorTypePred,
----------------
It does not look like the surrounding methods are consistent on this, but given that rank is int64_t (and unsigned at other places), consider a similar type for this; but perhaps this is more for a follow-up cleanup of our types
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75771/new/
https://reviews.llvm.org/D75771
More information about the llvm-commits
mailing list