[PATCH] D75727: [NFC][llvm-dwarfdump] Always use 'const Twine &'

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 9 06:57:36 PDT 2020

Previous message: [PATCH] D73794: [MLIR] Remove all-reduce lowering from GPU to NVVM. Use in-dialect lowering instead.
Next message: [PATCH] D75727: [NFC][llvm-dwarfdump] Always use 'const Twine &'
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

probinson accepted this revision.
probinson added a comment.

Twine can be the root of an arbitrary tree, and is not intended to be copied, the way StringRef is.  Passing by const ref is correct.
LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75727/new/

https://reviews.llvm.org/D75727

Previous message: [PATCH] D73794: [MLIR] Remove all-reduce lowering from GPU to NVVM. Use in-dialect lowering instead.
Next message: [PATCH] D75727: [NFC][llvm-dwarfdump] Always use 'const Twine &'
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list