[PATCH] D75742: [Object] Support large archive members

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D75742#1911048 <https://reviews.llvm.org/D75742#1911048>, @grimar wrote:

> Perhaps you could craft an object that has a broken size written to a header, e.g. (MAX_UINT32 + 1) ant test
>  that LLD does not crash and report an error with that would contain the size value found?


I'm not sure I understand what you mean here. The bug fixed by this patch manifests as attempting to read a section header table past the end of the file, because the result of the truncated size is failing to create a buffer that is large enough. This fix can therefore only be verified by attempting to use data in the latter part of a buffer that is > 4GB in size. The only alternative I can think of to having large files as inputs, is to create sparse files, but I'm not sure if the test would be portable consequently.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75742/new/

https://reviews.llvm.org/D75742