[PATCH] D73086: [WIP][DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX updated this revision to Diff 249038.
SouraVX added a comment.

Addressing comments by @Ikudrin, Thank a lot for detailed review!
-Removed FIXME.
-Modified error handling as per suggestion, their is still room for improvement but macinfo code which is also shared is getting bloated a bit. May be we can take this as separate issue. Sort of improving error handling in macro/macinfo.
-Removed un-necessary dependency from `Context` by passing `StringExtractor` as suggested.
-Removed, the binary file and related tests, kept a backup of it locally in case we decide to have that also.
-Replace `lineptr` with `debug_line_offset` in all asm test cases, asm comment  `lineptr` was motivated from gcc, but `debug_line_offset` seems like a better fit here. Thanks! for suggestion. I'll modify D72828 <https://reviews.llvm.org/D72828> also to emit `debug_line_offset` as comment till now that was also emitting `lineptr`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFContext.h
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h
  llvm/include/llvm/DebugInfo/DWARF/DWARFObject.h
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp
  llvm/test/DebugInfo/X86/debug-macro-macinfo.s
  llvm/test/DebugInfo/X86/debug-macro-v5.s
  llvm/test/DebugInfo/X86/unsupported-dwarf64-debug-macro-v5.s
  llvm/test/DebugInfo/X86/unsupported-opcode_operands_table-debug-macro-v5.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73086.249038.patch
Type: text/x-patch
Size: 25776 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200309/ecd5e026/attachment.bin>