[PATCH] D73086: [WIP][DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX added inline comments.


================
Comment at: llvm/test/DebugInfo/X86/dwarfdump-macro-macinfo.test:1
+RUN: llvm-dwarfdump -v %p/../Inputs/dwarfdump-macro-macinfo.elf-x86_64 | FileCheck %s
+
----------------
ikudrin wrote:
> SouraVX wrote:
> > ikudrin wrote:
> > > It is better to avoid using binary files. They are really hard to maintain. It is also much harder to check if the binary files themselves are correct.
> > this was generated by linking 2 different object containing v4 and v5 debuginfo. I noticed some errors while assembling the object generated by collapsing the asm of both into one. Is this a correct way ? for this case
> For sure it is possible to prepare an assembler source that will have both `.debug_macro` and `.debug_macinfo` sections.
Okay, If I understood correctly ? You just want `debug_macro` and `.debug_macinfo` that' fine. 
But we also need all other relevant section otherwise we'll loose coverage of crucial `DW_AT_macros` and `DW_AT_macro_info` which are part of info units having different representation(v4 & v5) of information. 
Are you okay with this ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086