[PATCH] D74691: [Attributor] Detect possibly unbounded cycles in functions

[Stefanos Baziotis via Phabricator via llvm-commits]

baziotis added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2450
+  // then it is a bounded loop.
+  for (auto L : LI->getLoopsInPreorder()) {
+    if (!SE->getSmallConstantMaxTripCount(L))
----------------
After a little bit of search, `clang-tidy` fails in the Harbomaster because you can declare `L` as `auto *L` (instead of `auto L`).
You can see the failed check by clicking on the Harbomaster failed build (https://reviews.llvm.org/B48509), then "pre-merge checks"(https://reviews.llvm.org/harbormaster/build/52266/), then "External Link clang-tidy linux" (https://results.llvm-merge-guard.org/amd64_debian_testing_clang8-4435/clang-tidy.txt).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74691/new/

https://reviews.llvm.org/D74691