[PATCH] D75206: [MLIR] Add explicit initial values for loop.parallel op.

[Alexander Belyaev via Phabricator via llvm-commits]

pifon2a marked 2 inline comments as done.
pifon2a added inline comments.


================
Comment at: mlir/lib/Dialect/LoopOps/LoopOps.cpp:434
+
   // Parse attributes and optional results (in case there is a reduce).
   if (parser.parseOptionalAttrDict(result.attributes) ||
----------------
mehdi_amini wrote:
> Have you considered having the type closer to the init?
> 
>   %res = loop.parallel (%i0) = (%arg0) to (%arg1) step (%arg2) init (%zero : f32) {
> 
> or 
> 
>   %res = loop.parallel (%i0) = (%arg0) to (%arg1) step (%arg2) init (%zero) -> f32 {
> 
> Having to skip visually the body is not the most readable to me.
> 
https://reviews.llvm.org/D75832 it is more readable indeed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75206/new/

https://reviews.llvm.org/D75206