[PATCH] D73086: [WIP][DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.
Sourabh Singh Tomar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 8 12:48:14 PDT 2020
SouraVX added a comment.
In D73086#1911797 <https://reviews.llvm.org/D73086#1911797>, @dblaikie wrote:
> In D73086#1911585 <https://reviews.llvm.org/D73086#1911585>, @SouraVX wrote:
>
> > Removed `SectionName` parameter from `dump` function, as it was un-necessary. Initialized `Version` to 0 inside struct so that their shouldn't be any warning(accessing uninitialized variable) when dumping macinfo section.
>
>
> Thanks! Yep, that's roughly what I had in mind.
Do you have any more outstanding comments, that I've mistakenly left *un-addressed* or regarding the overall implementation side , please share!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73086/new/
https://reviews.llvm.org/D73086
More information about the llvm-commits
mailing list