[PATCH] D75099: [AVR] Include AVR by default in LLVM builds

Sat Mar 7 10:16:53 PST 2020

aykevl added a comment.

In D75099#1902339 <https://reviews.llvm.org/D75099#1902339>, @dylanmckay wrote:

> > Hi Dylan - on the mailing list thread for this I raised a concern about disassembler support based on comments I'd seen in a recent patch. Can you please clarify the current status there?
>
> @aykevl perhaps you might have a more up-to-date answer than me here given the recent DWARF-dumping fixes you've made?

I don't think those two are related.

- Disassembler support has improved but is not nearly there. I have a number of local changes not even sent for review (went to work on other things). At least it shouldn't crash `llvm-objdump` now and should disassemble roughly half of the available instructions as I started with low hanging fruit. In my personal opinion, I don't think this should now block marking the AVR backend as stable.
- I haven't tested that DWARF patch exactly as it was when I committed it, but did test it when I submitted it for review and at that time it seemed to fix DWARF emission completely (llvm-dwarfdump does not show an error). I could have missed something, of course.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75099/new/

https://reviews.llvm.org/D75099