[PATCH] D75775: [mlir][Vector] Add a vector.matrix_multiply op on 1-D vectors

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache marked 2 inline comments as done.
nicolasvasilache added inline comments.


================
Comment at: mlir/include/mlir/Conversion/VectorToLLVM/ConvertVectorToLLVM.h:20
+/// Intrinsics. To lower to assembly, the LLVM flag -lower-matrix-intrinsics
+/// will be needed wheninvoking LLVM.
+void populateVectorToLLVMMatrixConversionPatterns(
----------------
mehdi_amini wrote:
> (Typo: missing space in `wheninvoking`)
> 
> Why do we need a special flag for matrix lowering?
Not sure, @fhahn ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75775/new/

https://reviews.llvm.org/D75775