[PATCH] D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/elf-dynamic-symbol.test:1
+## Test that llvm-objdump can dump dynamic symbols.
+
----------------
My idea is that after we have the binary format specific directory `test/tools/llvm-objdump/ELF/`. We can move tests under it.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1936
       GlobLoc = Global ? 'g' : 'l';
     char Debug = (Type == SymbolRef::ST_Debug || Type == SymbolRef::ST_File)
                  ? 'd' : ' ';
----------------
For .dynsym, `char Debug` should use 'D' instead of ' '


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75756/new/

https://reviews.llvm.org/D75756